Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(p2p): metrics for ExchangeServer #126

Merged
merged 7 commits into from
Oct 26, 2023
Merged

feat(p2p): metrics for ExchangeServer #126

merged 7 commits into from
Oct 26, 2023

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Oct 24, 2023 •
edited
Loading

Includes:

  • headersServed
  • headServeTime
  • rangeServeTime
  • getServeTime

Depends #125

@Wondertan Wondertan self-assigned this Oct 24, 2023
@Wondertan Wondertan marked this pull request as draft October 24, 2023 10:52
@Wondertan Wondertan changed the title feat(p2p): metrics for Exchange feat(p2p): metrics for ExchangeServer Oct 24, 2023
@Wondertan Wondertan force-pushed the p2p/exchange-server/metrics branch from 4896d8d to c917928 Compare October 24, 2023 15:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #126 (bb9cfaf) into main (09c272d) will decrease coverage by 2.86%.
Report is 1 commits behind head on main.
The diff coverage is 29.68%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   67.81%   64.95%   -2.86%     
==========================================
  Files          38       39       +1     
  Lines        3079     3276     +197     
==========================================
+ Hits         2088     2128      +40     
- Misses        843      990     +147     
- Partials      148      158      +10
Files Coverage Δ
p2p/helpers.go 78.26% <100.00%> (-2.26%) ⬇️
p2p/peer_stats.go 97.18% <100.00%> (ø)
p2p/peer_tracker.go 78.28% <100.00%> (-0.48%) ⬇️
p2p/session.go 89.79% <100.00%> (+0.10%) ⬆️
p2p/subscriber_metrics.go 7.50% <ø> (ø)
p2p/exchange.go 84.27% <77.77%> (-1.38%) ⬇️
p2p/server.go 83.58% <71.42%> (-1.42%) ⬇️
p2p/server_metrics.go 9.58% <9.58%> (ø)
p2p/exchange_metrics.go 11.30% <11.30%> (ø)

Wondertan
Wondertan commented Oct 25, 2023
View reviewed changes
p2p/server_metrics.go Outdated Show resolved Hide resolved
Wondertan
Wondertan commented Oct 25, 2023
View reviewed changes
p2p/server_metrics.go Outdated Show resolved Hide resolved
@Wondertan Wondertan force-pushed the p2p/exchange-server/metrics branch from c917928 to 93301a8 Compare October 25, 2023 14:05
@Wondertan Wondertan force-pushed the p2p/exchange-server/metrics branch from 617797f to a7ceae9 Compare October 25, 2023 14:32
@Wondertan Wondertan marked this pull request as ready for review October 25, 2023 14:32
renaynay
renaynay previously approved these changes Oct 26, 2023
View reviewed changes
vgonkivs
vgonkivs previously approved these changes Oct 26, 2023
View reviewed changes
walldiss
walldiss reviewed Oct 26, 2023
View reviewed changes
p2p/server.go Outdated Show resolved Hide resolved
p2p/server.go Outdated Show resolved Hide resolved
@Wondertan Wondertan dismissed stale reviews from vgonkivs and renaynay via bb9cfaf October 26, 2023 11:39
walldiss
walldiss reviewed Oct 26, 2023
View reviewed changes
p2p/server.go Outdated Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) October 26, 2023 12:16
@Wondertan Wondertan merged commit a8ce731 into main Oct 26, 2023
2 checks passed
@Wondertan Wondertan deleted the p2p/exchange-server/metrics branch October 26, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgonkivs vgonkivs vgonkivs approved these changes

@walldiss walldiss walldiss approved these changes

@renaynay renaynay renaynay left review comments

@tzdybal tzdybal Awaiting requested review from tzdybal tzdybal is a code owner

@gupadhyaya gupadhyaya Awaiting requested review from gupadhyaya gupadhyaya is a code owner

Assignees

@Wondertan Wondertan

Labels
kind:feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wondertan @codecov-commenter @walldiss @vgonkivs @renaynay